-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GNN plots available as an SPT CLI command and API endpoint #319
Comments
Here's an example configuration file for graph_plugin_plots.py as is.
Translating this to an API call,
What do you think @jimmymathews? |
We have to look at this from the web application perspective as well if we go the caching route. |
To keep the work here bounded, I propose that we make the new API endpoint have almost no parameters, maybe just the study. We can manually record (in that JSON format, I suppose) the detailed configuration for each study, and get the API handler to consult this configuration when regenerating the plot. |
Okay, so for the web API endpoint we expose only the study parameter, but for the actual function and CLI input we expose all parameters. The web API will look up a file or table with the parameters we've fixed for that study and call the function that way. (Where will that file or table be and how will it be looked up?) |
Yup, that is what I had in mind. |
The script It creates an isolated sql table and uses it / syncs it with some local file (local, that is, to the |
My thought's been to replace With the apiserver, the phenotype counts per specimen is fast because of the encoding you did, but if I'm understanding this correctly that functionality is in What would you say is the right way to approach this? |
This involves moving the current
analysis_replication/gnn_figure/graph_plugin_plots.py
out ofanalysis_relication/
and intospatialprofilingtoolbox/graphs/
, adding a CLI command for it toscripts/
, and an API endpoint that calls it tospatialprofilingtoolbox/apiserver/app/main.py
.The text was updated successfully, but these errors were encountered: