Better movie (IMDB) lookups #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additional "releasename parts" like "HEVC" for $followingList are added/reworked and avoid of matching any of entries of $followingList to count as moviename to gain a better lookup experience.
|
pull requests have to be based on dev not on master / 0.x |
|
@Maik0815 can you redo this PR against the dev branch please. We do not merge directly into the stable branch. |
|
Changed the base. Is this enough ? |
|
Unfortunately, no. The PR must be based from dev, not just targeting it. You need to switch to the dev branch on your machine, make the changes there, push to your github repo and make the PR from that. |
|
Now I've had time to take a look at the changes you are proposing, I'm pretty sure they do not fit in with what we are trying to do at this point in the code. There should absolutely NOT be any of the "$followingList" parts between the name and year in the match. Until I can actually run tests though, I cannot be certain. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #.
inaccurate IMDB lookups for movies foreign and native language.
Changes made by this pull request.
-additional "releasename parts" like "HEVC" for $followingList are added/reworked
-and avoid of matching any of entries of $followingList to count as moviename to gain a better lookup experience.