chore(deps): add dependency on tslib #984
Open
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@n1ru4l a few of these packages are broken for pnpm users as well because this dependency isn't listed -- could we get this fix merged? |
|
ping @n1ru4l -- this makes bundling this package break by default for well-behaved bundlers! |
airhorns
added a commit
to gadget-inc/js-clients
that referenced
this pull request
Oct 6, 2023
…raphql-live-query That package requires `tslib`, but doesn't list it as an explicit dependency. We need to import it ourselves until n1ru4l/graphql-live-query#984 is in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new npm isolated mode in v9.4.1, using undeclared dependencies is now an error (similar to Yarn PnP). This PR adds an explicit dependency on tslib for modules that are built with a reference to tslib.
fixes #967