Add Synchronised Lyrics SYLT support #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillt
suggested changes
Oct 12, 2021
| @@ -1,4 +1,4 @@ | |||
| module github.com/bogem/id3v2 | |||
| module github.com/tramhao/id3v2 | |||
| import ( | ||
| // "bytes" | ||
| "encoding/binary" | ||
| // "fmt" |
There was a problem hiding this comment.
These shouldn't be left in here.
n10v
reviewed
Oct 24, 2022
| package id3v2 | ||
|
|
||
| import ( | ||
| // "bytes" |
| import ( | ||
| // "bytes" | ||
| "encoding/binary" | ||
| // "fmt" |
| @@ -1,4 +1,4 @@ | |||
| module github.com/bogem/id3v2 | |||
| module github.com/tramhao/id3v2 | |||
| type SynchronisedLyricsFrame struct { | ||
| Encoding Encoding | ||
| Language string | ||
| TimestampFormat byte |
There was a problem hiding this comment.
Suggested change
| TimestampFormat byte | |
| TimestampFormat TimestampFormat |
| type TimestampFormat int | ||
|
|
||
| const ( | ||
| Unknown TimestampFormat = iota |
There was a problem hiding this comment.
IMO TimestampFormat is redundant here. Just use byte
Suggested change
| Unknown TimestampFormat = iota | |
| Unknown byte = iota |
There was a problem hiding this comment.
Please also prefix timestamp formats. Please also get rid of Unknown, I can't find such TimestampFormat in spec
const (
SYLTAbsoluteMpegFramesTimestampFormat = iota + 1
SYLTAbsoluteMillisecondsTimestampFormat
)| 7: "WebpageUrls", | ||
| 8: "ImageUrls", | ||
| } | ||
| ) |
There was a problem hiding this comment.
Please also use iota here:
const (
SYLTOtherContentType = iota
SYLTLyricsContentType
SYLTTextTranscriptionContentType
SYLTMovementContentType
SYLTEventsContentType
SYLTChordContentType
SYLTTriviaContentType
SYLTWebpageURLsContentType
SYLTImageURLsContentType
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to id3v2 sylt specification, add the sylt support.