Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ChapterFrame type for CHAP frames #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cnt0
Copy link
Contributor

@cnt0 cnt0 commented Feb 8, 2019

Add CHAP frames parser according to id3v2 documentation. It recognizes only one TIT2 embedded subframe and treats it like a title, which is enough to parse titles added by ffmpeg (example from ffmpeg documentation).

There's also one issue: this parser uses 2 functions, writeFrame and parseFrameHeader, with synchSafe parameter. From what I see there's no way to correctly determine its value when parsing subframe.

@n10v
Copy link
Owner

n10v commented Feb 10, 2019

Hello @cnt0! Thank you for your PR, but the implementation is not quite correct. As it said in documentation, there could be many embedded subframes in CHAP. The main goal of this library is not a cooperation of ffmpeg, but correct full implementation of id3 spec.

And also tests lack, that is very important.

@takaishi takaishi mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants