refactor!: use Service generic in transport connections
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
much nicer 🔥 |
|
OK, so I am trying to come up with cases where this is limiting, but so far can't find any. Also it seems that transport::Connection is unaffected and still has two type parameters. So LGTM. |
maybe it gets rid of the errors
# Conflicts: # Cargo.lock
rklaehn
force-pushed
the
refactor/service-conn
branch
from
b52d24e
to
2a25a7a
Compare
to get rid of some weird warnings about non_local_definitions from derive_more macros
rklaehn
force-pushed
the
refactor/service-conn
branch
from
2a25a7a
to
9235fdf
Compare
rklaehn
approved these changes
May 13, 2024
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
May 24, 2024
## Description Adapts iroh for n0-computer/quic-rpc#76 Wit this change, a quic client is `pub type QuicIroh = Iroh<QuinnConnection<RpcService>>` instead of `pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest, ProviderResponse>>` ## Breaking Changes * Increased mimimal supported rust version (MSRV) from 1.75 to 1.76 * The generics of the iroh clients changed: Instead of taking `ProviderRequest, ProviderResponse` as generics, they now take `RpcService` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <me@dignifiedquire.com>
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
May 24, 2024
## Description Adapts iroh for n0-computer/quic-rpc#76 Wit this change, a quic client is `pub type QuicIroh = Iroh<QuinnConnection<RpcService>>` instead of `pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest, ProviderResponse>>` ## Breaking Changes * Increased mimimal supported rust version (MSRV) from 1.75 to 1.76 * The generics of the iroh clients changed: Instead of taking `ProviderRequest, ProviderResponse` as generics, they now take `RpcService` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <me@dignifiedquire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the transport connection and endpoint struct to be generic over
S: Serviceinstead ofIn: RpcMessage, Out: RpcMessage. With this change, the public API surface of a crate using quic-rpc can be reduced to only make the service struct public and hide the RPC message types.E.g. in Iroh, a quic client would now be
Client<QuinnConnection<RpcService>>instead of
Client<QuinnConnection<ProviderRequest, ProviderResponse>>Breaking changes
The change breaks all transport types, they are now generic over
S: Serviceinstead ofIn: RpcMessage, Out: RpcMessage.