New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7 #183
Open
n-ce
wants to merge
67
commits into
main
Choose a base branch
from
oembed
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ytify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…coming fetch requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this pr is enable link previews for
https://ytify.netlify.app?s=id
on the social medias.The next stage is converting LIT components to Solid-JS. There are advantages to this such as component transparency and reduced complexity in wrapping the components around points of usage. We use Solid-JS simply as a library and not a framework in this case. Our priority is still HTML which is why the
toggle-switch
will continue to be a web component so that it can be written directly in HTML without any JS involved in injecting it.The third stage would be involving breaking down the
fetchList
method and creating collection item components. The advantages to this is only loading collections on demand and ontolist
instead of their own collapsable children.