Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update native projects #6

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Update native projects #6

merged 5 commits into from
Oct 4, 2018

Conversation

Arrnas
Copy link
Contributor

@Arrnas Arrnas commented Oct 2, 2018

Retry of #5, had a number of issues doing this:

Managed to successfully launch on ios and android.

@Arrnas Arrnas requested review from donce and shroomist October 2, 2018 15:44
@@ -41,7 +41,7 @@
"axios": "^0.18.0",
"computed-async-mobx": "^4.1.0",
"expo": "^27.0.1",
"mobx": "^5.1.2",
"mobx": "^4.3.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decide to downgrade mobx instead of upgrading javascriptcore in android native project as it require bumping min sdk version

@shroomist
Copy link
Contributor

have you tried this?
mobxjs/mobx-react#498 (comment)

@Arrnas
Copy link
Contributor Author

Arrnas commented Oct 2, 2018

@shroomist saw it as an option but didn't want to mess with android native dependency and the change requires setting the minimum android SDK version to 21.. Having said that I don't know about the drawbacks of using mobx v4 vs v5, do you think it would be worth it to use v5?

@shroomist
Copy link
Contributor

recently I've came across Symbols usage several times in different libs.
in our codebase we're increasingly using features from future JS proposals via babel.

this one seems like it's some default value, that's been left behind, not updated at react-native project.
I'm wondering, what's the down side of using the newer version of sdk 21 vs 16?
are we dropping support for legacy devies?

@donce might also have an opinion here

@Arrnas
Copy link
Contributor Author

Arrnas commented Oct 2, 2018

sdk 21 is Android 5.0 (LOLLIPOP) and according to this usage bellow that is ~18% while usage bellow sdk 16 is ~2% ¯\(ツ)

@shroomist
Copy link
Contributor

in that case we're dropping support for jellybean up to lollipop, which are no longer maintained and together <8% of devices as of february 2018.
I'd rather drop those and have a more up to date environment.

@donce
Copy link
Contributor

donce commented Oct 3, 2018

Since this fixed master builds for android, I fully approve it :) We can decide later whether we need new features for MobX or not - we're not using them ATM.

Copy link
Contributor

@shroomist shroomist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be eager to bump the sdk versions later on ;D

@Arrnas Arrnas merged commit 18c9317 into master Oct 4, 2018
@Arrnas Arrnas deleted the feauture/update_native_projects branch October 4, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants