Skip to content

Commit

Permalink
Bump node to 20
Browse files Browse the repository at this point in the history
  • Loading branch information
tadaskay committed Dec 19, 2023
1 parent 40826cb commit bd0a1c6
Show file tree
Hide file tree
Showing 5 changed files with 257 additions and 562 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ on: [pull_request, push]
jobs:
lint:
name: Lint
runs-on: macos-12
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: "yarn"
- run: yarn install --frozen-lockfile
- run: yarn lint
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ jobs:

strategy:
matrix:
os: [macos-11, windows-2022, ubuntu-20.04]
os: [macos-13, windows-2022, ubuntu-20.04]

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: "yarn"
- run: yarn install --frozen-lockfile
- uses: battila7/get-version-action@v2
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"bundle-dev": "yarn build && CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder"
},
"engines": {
"node": ">=18"
"node": ">=20"
},
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^6.5.1",
Expand All @@ -34,7 +34,7 @@
"bignumber.js": "^9.0.2",
"byte-size": "^8.0.0",
"electron-log": "^4.4.8",
"electron-updater": "^5.2.1",
"electron-updater": "^6.1.7",
"history": "^5.3.0",
"lodash": "^4.17.21",
"mkdirp": "^1.0.4",
Expand Down Expand Up @@ -71,7 +71,7 @@
"@types/async-retry": "^1.4.3",
"@types/electron-devtools-installer": "^2.2.2",
"@types/lodash": "^4.14.179",
"@types/node": "^16.0.0",
"@types/node": "^20.10.5",
"@types/react": "^18.0.14",
"@types/react-autosuggest": "^10.1.5",
"@types/react-dom": "^18.0.5",
Expand All @@ -86,7 +86,7 @@
"chmodr": "^1.2.0",
"cross-env": "^7.0.3",
"electron": "^28.0.0",
"electron-builder": "^23.3.3",
"electron-builder": "^24.9.1",
"electron-devtools-installer": "^3.2.0",
"electron-download": "^4.1.1",
"electron-webpack": "^2.8.2",
Expand Down
1 change: 1 addition & 0 deletions src/utils/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const uid = (): string => {
// getuid only available on POSIX
// and it's not needed on windows anyway
if (platform() !== "win32") {
// @ts-ignore

Check failure on line 14 in src/utils/user.ts

View workflow job for this annotation

GitHub Actions / Lint

Do not use "@ts-ignore" because it alters compilation errors
uid = process.getuid()
}
return uid.toString()
Expand Down

0 comments on commit bd0a1c6

Please sign in to comment.