Improvements to focus order #4952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when users makes mistake or leaves the email input empty the focus returns to the begining of the page causing the user to have to travel across multiple elements to be able to re-enter their email. With this fix the focus goes back to the email input element.
The current behaviour for the focus state when providing an update to a report is going directly into the first input after the .form-section-preview and its content, making it difficult for users using assistive devices to edit an "update" once they have pressed the "continue" button, because they would need to travel across the whole page in order to reach "Edit your update" button. With this fix the focus state goes directly to the content inside ".form-section-preview" if this element exist.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4952 +/- ##
==========================================
+ Coverage 82.62% 82.80% +0.18%
==========================================
Files 391 392 +1
Lines 30483 31045 +562
Branches 4813 4966 +153
==========================================
+ Hits 25186 25707 +521
- Misses 3861 3893 +32
- Partials 1436 1445 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/mysociety/societyworks/issues/4212
Both of these fixes should improve how users using assistive devices travel across inputs by modifying which focus element we are focusing, making it easier to rectify errors or previous steps.
List of commits
Added fix to email input focus behaviour when there is an error
First commit fixes:
SW ref 30: Local RSS feeds and email alerts - part 2
Added fix for focus behaviour in pages with a .form-section-preview
SW ref 29: Reported issue - provide an update form - tell us about you (step 2)
[Skip changelog]