RF24: Implement MY_RF24_INVERTED_ACK hack #1463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekromant
force-pushed
the
development
branch
2 times, most recently
from
06870a9
to
3d70560
Compare
This hack allows better nRF24L01<-->SI24R01 interoperability Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
nekromant
force-pushed
the
development
branch
from
3d70560
to
0defe3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack allows better nRF24L01<-->SI24R01 interoperability
I have been playing with some of the fakes I got from aliexpress and found out a few ways to properly get them on my existing mysensors network. I have implemented a MY_RF24_INVERTED_ACK define, that comments out RF24_setAutoACK(_BV(RF24_ENAA_P0)). This small edit allows the nodes to work on my network (composed mostly of genuine, or at least better fakes) without an issue.
I have also updated the docs with other tips I've found.
P.S. I haven't tested the 'repeater' feature with this one on, but it should work threoretically
EDIT: Please don't merge it. Found some issues with one of the fakes, will fix it ASAP, perhaps with yet anotherworkaround
Testing results:
A newer nRF24L01+ order, package marking "NRF M 24L01+ 2012AB". Doesn't work unless I manually set static Parent ID and Node ID. When it works, I can see tons of "492097 !TSF:MSG:SEND,14-14-0-0,s=1,c=1,t=16,pt=2,l=2,sg=0,ft=0,st=NACK:1" messages. However unlike the COB version it works as a BLe beacon and has no problems connecting with rf24boot bootloader.Turned out to be the 'magic finger' problem as described here: https://ncrmnt.org/2021/01/03/nrf24l01-fixing-the-magic-finger-problem/ None of the modules were working, untill I soldered the 1pF cap.Signed-off-by: Andrew Andrianov andrew@ncrmnt.org