remove Array.from usage and update to beta5

mynamesleon · Jan 9, 2020 · 51302d5 · 51302d5
1 parent 40f37d8
commit 51302d5
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/examples/index.html b/examples/index.html
@@ -126,6 +126,9 @@
                 margin-bottom: 10px;
                 padding: 7px 10px;
             }
+            [role='tab'] {
+                cursor: pointer;
+            }
             [role='tabpanel'] {
                 width: 100%;
                 margin-right: 0;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "aria-tablist",
-    "version": "1.0.0-beta.4",
+    "version": "1.0.0-beta.5",
     "description": "Dependency-free plain JavaScript module for WCAG compliant tablists",
     "main": "dist/aria-tablist.min.js",
     "scripts": {

diff --git a/src/aria-tablist.js b/src/aria-tablist.js
@@ -251,10 +251,11 @@ class Tablist {
 
         // create tabs and panels arrays
         // only for tabs that control an element, or have a panel labelled by it
-        Array.from(tabs).forEach(tab => {
+        for (let i = 0, l = tabs.length; i < l; i += 1) {
+            const tab = tabs[i];
             // do not process non-element nodes
             if (tab.nodeType !== 1) {
-                return;
+                continue;
             }
 
             // ensure tab has an associated panel
@@ -266,7 +267,7 @@ class Tablist {
                 tab.removeAttribute('aria-controls');
                 tab.removeAttribute('aria-selected');
                 tab.removeAttribute('aria-expanded');
-                return;
+                continue;
             }
 
             // ensure element has the tab role
@@ -278,7 +279,7 @@ class Tablist {
 
             // store index on the tab itself for arrow keypresses
             tab[TAB_INDEX_PROP] = this.tabs.length - 1;
-        });
+        }
     }
 
     /**