Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one build npm script. Add github actions CI #122

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

romang-at-guarda-co
Copy link

@romang-at-guarda-co romang-at-guarda-co commented Dec 20, 2021

This allows users to build everything like this:

npm ci
npm run build

And also adds a github workflow which runs these commands and npm run test afterwards to make sure this build works.

@devinpearson
Copy link
Contributor

Thanks for the submission @romang-at-guarda-co

Ill have a look at it properly tomorrow. If you are interested in taking it further. Ive made a number of changes to our newer library that can be found here. https://github.com/mymonero/mymonero-utils/tree/master/packages/mymonero-monero-client and here: https://github.com/mymonero/mymonero-utils/tree/master/packages/mymonero-wallet-manager

The newer code is using boost headers and the latest emscripten docker image to do the builds. these would fit well with the changes you have made.

@romang-at-guarda-co
Copy link
Author

Sorry, I think I'm interested in this repo specifically (I have legacy code that depends on it).

@devinpearson
Copy link
Contributor

no problem. just suggesting that you can drop the downloading of boost and the need for a custom emscripten docker container. the code in this repo does work with the latest emscripten and boost headers.

@romang-at-guarda-co
Copy link
Author

I think I got it.

@devinpearson devinpearson changed the base branch from master to develop December 24, 2021 07:22
@devinpearson devinpearson changed the base branch from develop to master December 24, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants