Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Feature caching improvements #150

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Feature caching improvements #150

wants to merge 13 commits into from

Conversation

JN-Jones
Copy link
Contributor

Also fixed #148 as otherwise I wasn't able to cache the forum queries.

@JN-Jones
Copy link
Contributor Author

@euantorano @wpillar can we merge this? Would like to have it merged while working on #147 as atm only some permissions are cached which already confused me.

wpillar
wpillar reviewed May 25, 2015
View reviewed changes
app/Database/Collections/TreeCollection.php
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;

class TreeCollection extends Collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a collection of Tree objects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a collection of objects which can be displayed as tree.

@JN-Jones
Rename whereSlug to getBySlug
dd49ebe
@JN-Jones
Merge branch 'fix-composer-update' into feature-caching_improvements
c4aaea2 
Conflicts:
	app/Database/Models/AbstractCachingModel.php
	app/Database/Models/Forum.php
	app/Database/Models/Post.php
	app/Database/Models/Role.php
	app/Database/Models/Topic.php
	app/Services/Registrar.php
	composer.json
	composer.lock
@JN-Jones
Forgot to rerun composer
b3bc533
@JN-Jones
Copy link
Contributor Author

Don't know why it shows all those .css files etc as changed. It's the same as the one in master...

Also note that this is based on #174

@euantorano
Copy link
Member

More conflicts 😢

@JN-Jones
Merge branch 'master' into feature-caching_improvements
1fe2074 
# Conflicts:
#	app/Database/Models/Forum.php
#	app/Database/Models/Post.php
#	app/Database/Models/Topic.php
#	composer.lock
@JN-Jones
Copy link
Contributor Author

Should be fixed but haven't tested it yet

@JN-Jones
Copy link
Contributor Author

Though this seems to work now I'd like to improve it a bit as the moderation log page produces quite a lot of queries: 56 statements were executed, 11 of which were duplicated.

@JN-Jones
Copy link
Contributor Author

This is finished now as the moderation log will/should be fixed in #169 @euantorano

@euantorano
Copy link
Member

Ok, I'll have a look when I get back from my holiday thanks.

On 27 Oct 2015, at 13:24, Jones notifications@github.com wrote:

This is finished now as the moderation log will/should be fixed in #169 @euantorano

—
Reply to this email directly or view it on GitHub.

@JN-Jones
Copy link
Contributor Author

I've run composer update again so we're up to date after this has been merged.

@JN-Jones
Copy link
Contributor Author

JN-Jones commented Nov 2, 2015

@euantorano ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nestedset dependency
3 participants
@JN-Jones @euantorano @wpillar