Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in php8 when set_time_limit is disabled #4730

Open
wants to merge 1 commit into
base: feature
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion admin/modules/tools/backupdb.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ function clear_overflow($fp, &$contents)
admin_redirect("index.php?module=tools-backupdb&action=backup");
}

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

// create an array with table prefix appended for checks, as full table names are accepted
$binary_fields_prefixed = array();
Expand Down
3 changes: 2 additions & 1 deletion admin/modules/tools/file_verification.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
die("Direct initialization of this file is not allowed.<br /><br />Please make sure IN_MYBB is defined.");
}

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

$page->add_breadcrumb_item($lang->file_verification, "index.php?module=tools-file_verification");

Expand Down
3 changes: 2 additions & 1 deletion admin/modules/tools/optimizedb.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
admin_redirect("index.php?module=tools-optimizedb");
}

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

$db->set_table_prefix('');

Expand Down
3 changes: 2 additions & 1 deletion admin/modules/tools/system_health.php
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@
flash_message($lang->error_utf8mb4_version, 'error');
admin_redirect("index.php?module=tools-system_health&action=utf8_conversion");
}
@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

$old_table_prefix = $db->table_prefix;
$db->set_table_prefix('');
Expand Down
3 changes: 2 additions & 1 deletion admin/modules/tools/tasks.php
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,8 @@ function check_time_values($value, $min, $max, $return_type)
}

ignore_user_abort(true);
@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

$plugins->run_hooks("admin_tools_tasks_run");

Expand Down
3 changes: 2 additions & 1 deletion inc/tasks/backupdb.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ function task_backupdb($task)
global $db, $config, $lang, $plugins;
static $contents;

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

if(!defined('MYBB_ADMIN_DIR'))
{
Expand Down
3 changes: 2 additions & 1 deletion inc/tasks/checktables.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ function task_checktables($task)
return;
}

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

$ok = array(
"The storage engine for the table doesn't support check",
Expand Down
3 changes: 2 additions & 1 deletion install/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
*
*/

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

define('MYBB_ROOT', dirname(dirname(__FILE__))."/");
define("INSTALL_ROOT", dirname(__FILE__)."/");
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade10.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade10_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade11.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade11_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade12.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"requires_deactivated_plugins" => 1,
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

// We need to globalize $db here because when this script is called
// during load_module $db is not globalized in the function
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade13.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade13_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade14.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade14_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade15.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade15_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade16.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do from 1.4.5 to 1.4.13 */

3 changes: 2 additions & 1 deletion install/resources/upgrade17.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade17_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade18.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade18_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade19.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.6.1 and 1.6.2 */

3 changes: 2 additions & 1 deletion install/resources/upgrade20.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade20_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade21.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade21_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade22.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.6.5 */

3 changes: 2 additions & 1 deletion install/resources/upgrade23.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade23_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade24.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.6.7 */
3 changes: 2 additions & 1 deletion install/resources/upgrade25.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.6.8 */
3 changes: 2 additions & 1 deletion install/resources/upgrade26.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade26_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade27.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);


/* Nothing to do for 1.6.10 */
3 changes: 2 additions & 1 deletion install/resources/upgrade28.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.6.11 or 1.6.12 */
3 changes: 2 additions & 1 deletion install/resources/upgrade29.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.6.13 */

3 changes: 2 additions & 1 deletion install/resources/upgrade3.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"requires_deactivated_plugins" => 1,
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade3_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade30.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade30_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade31.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade31_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade32.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade32_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade33.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade33_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade34.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.8.5 */
3 changes: 2 additions & 1 deletion install/resources/upgrade35.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade35_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade36.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade36_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade37.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade37_dbchanges()
{
Expand Down
3 changes: 2 additions & 1 deletion install/resources/upgrade38.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.8.9 */
3 changes: 2 additions & 1 deletion install/resources/upgrade39.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"revert_all_settings" => 0
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

/* Nothing to do for 1.8.10 */
3 changes: 2 additions & 1 deletion install/resources/upgrade4.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"requires_deactivated_plugins" => 1,
);

@set_time_limit(0);
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

function upgrade4_dbchanges()
{
Expand Down