Inhibit drag-n-drop in the editor #4368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily prevent drag-n-drop of images into the editor until PR mybb#4359 is updated and included in 1.9.
|
This may introduce confusion to the UI, given the drop target feedback. |
|
Fair criticism. I think it's less confusing than the current situation, but I'll see if I can address your criticism. |
|
Please see what you think of the commit I've just added, which hopefully resolves the issue satisfactorily. |
|
This looks good to me, I just want to test in a few other browsers than just Safari and Firefox. I'll test Chrome tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily prevent drag-n-drop of images into the editor until PR #4359
is updated and included in 1.9.
Based on / inspired by @effone's code/approach in that PR.