Working on #2972 Template Conversion to Twig Format (managegroup.php) #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euantorano
requested changes
Feb 6, 2018
managegroup.php
Outdated
| ORDER BY u.username ASC | ||
| "); | ||
| while ($user = $db->fetch_array($query)) { | ||
| $user['reason'] = htmlspecialchars_uni($user['reason']); |
There was a problem hiding this comment.
The use of htmlspecialchars_uni() here (and perhaps below?) will cause double escaping.
managegroup.php
Outdated
|
|
||
| if ($usergroup['type'] == 5) { | ||
| $usergroup['usergrouptype'] = $lang->group_public_invite; | ||
| } |
managegroup.php
Outdated
| WHERE g.gid = '{$gid}' | ||
| "); | ||
|
|
||
| $leaders_array = array(); |
There was a problem hiding this comment.
For consistency with the below $leaders = [], can you use square brackets here too to initialise the array?
managegroup.php
Outdated
| $leaders_array[] = $leader['uid']; | ||
|
|
||
| // Get commas... | ||
| if ($loop != $leader_count) { |
There was a problem hiding this comment.
This logic could be done in the view itself, using the loop.last variable.
|
All changes have been made |
euantorano
approved these changes
Feb 16, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2972 for managegroup.php