#2972 (stats.php) forum statistics to twig #3011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding a composer configuration file for the project, with no defined dependencies. * Rquire autoload file Signed-off-by: Euan Torano <euantorano@gmail.com> * Removing global.php from files to autoload
* Initial admin routing setup * Adding a basic layout for the ACP
* Starting work on moving front end to Twig This marks the start of integrating Twig into the front end. There are two global variables shared with all views - mybb and lang. Signed-off-by: Euan Torano <euantorano@gmail.com> * Starting the long process of template translation Not much to show yet, but this is a first step towards seeing that key variables such as $mybb, $lang and $theme can be accessed. Need to sort out loading of stylesheets still to make things look decent. Signed-off-by: Euan Torano <euantorano@gmail.com> * Changing how language is registered There is a new LangExtension that provides a `trans` function along with the `lang` global. Signed-off-by: Euan Torano <euantorano@gmail.com> * Showing drafts by adding drafts to an array Moved setting of theme global to theme extension. Need to fix the use of |raw in some places - we should generate the HTML inside the views themselves instead… Signed-off-by: Euan Torano <euantorano@gmail.com> * Finished the majority of work on the drafts page Signed-off-by: Euan Torano <euantorano@gmail.com> * Add return type hints Signed-off-by: Euan Torano <euantorano@gmail.com> * Fixing trow usage currently following 1.8 standard Signed-off-by: Euan Torano <euantorano@gmail.com>
…2975) * Working on #2972 Template Conversion to Twig Format (warnings.php) Part 1 - User warning log * Coding standards * Working on #2972 Template Conversion to Twig Format (warnings.php) Part 2 - Warning details * Working on #2972 Template Conversion to Twig Format (warnings.php) Part 3 - Warning a user
* Starting work on translatig subscribed threads Signed-off-by: Euan Torano <euantorano@gmail.com> * Finish subscriptions page in UCP Signed-off-by: Euan Torano <euantorano@gmail.com> * Use `&` rather than `&` in URL. Signed-off-by: Euan Torano <euantorano@gmail.com> * Move HTML out of PHP into view Also use `threadprefix` as `raw` as it can contain HTML.
…2984) * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 1 - Adding an event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 2 - Editing an event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 3 - Moving event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 4 - Viewing an event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 5 - Day view * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 6 - Week view * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 7 - Calendar * Moved gobutton to inline * Code updates -Added selected and checked HTML to templates -Move day select options to array * More code updates - Moved month select options to array - Split bottom calendar jump/month jump into seperate Twig file - Converted user stars to Twig
…ing on PHP 7.2 (#2995) * [FIX] string to array conversation causing Illegal string offset warning on PHP 7.2 * Use 4 spaces instead of tab
Signed-off-by: Euan Torano <euantorano@gmail.com>
(cherry picked from commit afa523f)
|
Not sure about this lines. It's not very messy, but maybe splitting this lang into two parts would be better idea. |
|
@Matslom It may make sense to split that language variable into two parts, yeah. It doesn't look too bad like this though, so I'd be happy to merge this if you're happy with it. |
|
@euantorano So I will split it to two parts. Tomorrow most likely. |
|
Great, thank you very much.
… On 25 Jan 2018, at 09:44, Matslom ***@***.***> wrote:
Not sure about this lines. It's not very messy, but maybe splitting this lang into two parts would be better idea.
https://github.com/Matslom/mybb/blob/fabee05ad8ff33ac807066949b94b1f73b23d4e1/inc/views/base/stats/stats.twig#L41-L42
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Unfortunately this PR is now conflicted due to the rebase after releasing 1.8.15. Any chance you could take a look at it? |
|
@euantorano I will try fix it in this week. |
effone
added
the
s:conflict
|
@euantorano You can close it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2972