Working on #2972 Template Conversion to Twig Format (memberlist.php) #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1 - Member list
euantorano
reviewed
Jan 18, 2018
| <tr> | ||
| <td class="thead" colspan="{{ memberlist.colspan }}"> | ||
| <div class="float_right"> | ||
| <a href="memberlist.php?username_match=begins&username={{ lang.a }}" style="padding: 5px;">{{ lang.a }}</a> |
There was a problem hiding this comment.
Might make sense to use a loop here if possible.
| <tr> | ||
| <td class="tcat" width="1%"><span class="smalltext"><strong>{{ lang.avatar }}</strong></span></td> | ||
| <td class="tcat"> | ||
| <span class="smalltext"><a href="memberlist.php?perpage={{ mybb.input.perpage }}{{ memberlist.search_url }}&sort=username&order=ascending"><strong>{{ lang.username }}</strong></a> {% if memberlist.orderarrow.username %}<span class="smalltext">[<a href="memberlist.php?perpage={{ mybb.input.perpage }}{{ memberlist.search_url }}&sort=username&order={{ memberlist.oppsortnext }}">{{ memberlist.oppsort }}</a>]</span>{% endif %}</span> |
There was a problem hiding this comment.
Can we split these long lines into multiple lines?
|
@PaulBender Can you update #2972 with all the templates you've changed and got merged please? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #2972
This PR is for the member list (memberlist.php).