Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index page (index.php) for #2972 #2997

Closed
wants to merge 18 commits into from
Closed

Index page (index.php) for #2972 #2997

wants to merge 18 commits into from

Conversation

Matslom
Copy link
Contributor

@Matslom Matslom commented Jan 18, 2018 •
edited

FOR #2972

templates;
index

  • index
  • index_birthdays
  • index_birthdays_birthday
  • index_boardstats
  • index_logoutlink
  • index_stats
  • index_statspage
  • index_whosonline
  • index_whosonline_memberbit
+ index -> index/index.twig
- index_birthdays
- index_birthdays_birthday
+ index_boardstats -> index/boardstats.twig
- index_logoutlink
- index_stats
- index_statspage
- index_whosonline
- index_whosonline_memberbit

euantorano and others added 14 commits December 11, 2017 15:58
@euantorano
#2907 - Add Composer configuration (#2908)
fd5a437 
* Adding a composer configuration file for the project, with no defined dependencies.

* Rquire autoload file

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Removing global.php from files to autoload
@euantorano
Adding a composer configuration file for the project, with no defined…
c7eeb11 
… dependencies.
@euantorano
Fixes #2920 - adds the Laravel Container (#2934)
f57c16b 
* Adding Laravel container

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Updating doc comment for app() function

Signed-off-by: Euan Torano <euantorano@gmail.com>
@036 @euantorano
Move autoloader to bootstrap file (#2937)
608ea57
@euantorano
Admin CP rewrite (#2941)
37fb723 
* Initial admin routing setup

* Adding a basic layout for the ACP
@euantorano
Start implementing Twig for the front-end (#2963)
97b3aed 
* Starting work on moving front end to Twig

This marks the start of integrating Twig into the front end. There are two global variables shared with all views - mybb and lang.

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Starting the long process of template translation

Not much to show yet, but this is a first step towards seeing that key variables such as $mybb, $lang and $theme can be accessed.

Need to sort out loading of stylesheets still to make things look decent.

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Changing how language is registered

There is a new LangExtension that provides a `trans` function along with the `lang` global.

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Showing drafts by adding drafts to an array

Moved setting of theme global to theme extension.

Need to fix the use of |raw in some places - we should generate the HTML inside the views themselves instead…

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Finished the majority of work on the drafts page

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Add return type hints

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Fixing trow usage currently following 1.8 standard

Signed-off-by: Euan Torano <euantorano@gmail.com>
@Starpaul20 @euantorano
Working on #2972 Template Conversion to Twig Format (warnings.php) (#…
9bca15a 
…2975)

* Working on #2972 Template Conversion to Twig Format (warnings.php)
Part 1 - User warning log

* Coding standards

* Working on #2972 Template Conversion to Twig Format (warnings.php)
Part 2 - Warning details

* Working on #2972 Template Conversion to Twig Format (warnings.php)
Part 3 - Warning a user
@Starpaul20 @euantorano
Working on #2972 Template Conversion to Twig Format (sendthread.php) (#…
dc9f2ca 
…2983)

* Working on #2972 Template Conversion to Twig Format (sendthread.php)

* Removed double escaping
@euantorano
Starting work on translating subscribed threads to Twig (#2971)
1a00bdc 
* Starting work on translatig subscribed threads

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Finish subscriptions page in UCP

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Use `&amp;` rather than `&` in URL.

Signed-off-by: Euan Torano <euantorano@gmail.com>

* Move HTML out of PHP into view

Also use `threadprefix` as `raw` as it can contain HTML.
@euantorano
Announcements — For #2972 (#2987)
e0d9afc 
* For #2972

* added whitespace

* remove htmlspecialchars_uni
@Starpaul20 @euantorano
Working on #2972 Template Conversion to Twig Format (calendar.php) (#…
d398853 
…2984)

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 1 - Adding an event

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 2 - Editing an event

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 3 - Moving event

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 4 - Viewing an event

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 5 - Day view

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 6 - Week view

* Working on #2972 Template Conversion to Twig Format (calendar.php)
Part 7 - Calendar

* Moved gobutton to inline

* Code updates
-Added selected and checked HTML to templates
-Move day select options to array

* More code updates
- Moved month select options to array
- Split bottom calendar jump/month jump into seperate Twig file
- Converted user stars to Twig
@Matslom @euantorano
[FIX] string to array conversation causing Illegal string offset warn…
ae2a9b7 
…ing on PHP 7.2 (#2995)

* [FIX] string to array conversation causing Illegal string offset warning
on PHP 7.2

* Use 4 spaces instead of tab
[WIP] Initial index templates conversion
21a77a6
@euantorano
Translating forum subscriptions to Twig (#2989)
067261c 
Signed-off-by: Euan Torano <euantorano@gmail.com>
euantorano
euantorano requested changes Jan 18, 2018
View reviewed changes
Copy link
Member

@euantorano euantorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just a minor comment about indentation.

inc/views/base/index/boardstats.twig Outdated
<tr>
<td class="tfoot" style="text-align: right">
<span class="smalltext">
{% if mybb.user.uid != 0 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here looks a little bit weird.

@Ben-MyBB Ben-MyBB added b:1.8 Branch: 1.8.x b:1.9 Branch: 1.9.x and removed b:1.8 Branch: 1.8.x labels Jan 22, 2018
@Matslom
Copy link
Contributor Author

Matslom commented Jan 24, 2018

@euantorano I had to remove forumbit templates from my todo list in this PR. They are too complex and time consuming and I can't handle them now.

@Matslom Matslom changed the title [WIP] Index page (index.php) for #2972 Index page (index.php) for #2972 Jan 24, 2018
@euantorano
Copy link
Member

@Matslom No problem. I'm going to leave this open for now then until the forum bit templates are done - otherwise it might make it hard to test other PRs without an index page to navigate into forums and threads 😉

@Matslom
Copy link
Contributor Author

Matslom commented Jan 24, 2018

It may stay open, but I've add forums raw html, so they are rendered from old templates.

@euantorano euantorano mentioned this pull request Feb 27, 2018
Merged
@effone effone added the s:conflict Status: Conflict. Solution incompatible with current code label May 12, 2018
@euantorano euantorano closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euantorano euantorano euantorano requested changes

Assignees
No one assigned
Labels
b:1.9 Branch: 1.9.x s:conflict Status: Conflict. Solution incompatible with current code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Matslom @euantorano @Ben-MyBB @effone @036 @Starpaul20