Reports — For #2972 #2996
Merged
Reports — For #2972 #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 17, 2018 17:16
report_reason, report_reasons
...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template.
WildcardSearch
added
t:enhancement
|
@mybb/developers this seems to be working correctly. It should be ready to test. |
Matslom
reviewed
Jan 19, 2018
report.php
Outdated
| $templatelist = "report,report_thanks,report_error,report_reasons,report_error_nomodal,forumdisplay_password_wrongpass,forumdisplay_password"; | ||
| require_once "./global.php"; | ||
| require_once MYBB_ROOT.'inc/functions_modcp.php'; | ||
| $templatelist = 'report,report_thanks,report_error,report_reasons,report_error_nomodal,forumdisplay_password_wrongpass,forumdisplay_password'; |
There was a problem hiding this comment.
This is unnecessary right now, right?
There was a problem hiding this comment.
Yes. I just got an answer on Discord from Euan. I will handle it tonight.
There was a problem hiding this comment.
Done @Matslom
|
from the gui side of this, I didn't see any issues. |
|
@WildcardSearch This still has the |
|
Yes, @euantorano I am not up-to-speed on the labels and when they should be applied/removed. |
|
No problem, I'll give it a test 👍 |
|
Great! |
euantorano
pushed a commit
that referenced
this pull request
Mar 16, 2018
* Initial Cleanup and Main Template Conversion [WIP] * report_thanks * report_thanks * Errors report_error_nomodal, * report_duplicate * Report Reason report_reason, report_reasons * Separated `nomodal` Content ...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template. * Adjust Alignment * Remove unused assignment * Remove Template Cache List
euantorano
pushed a commit
to euantorano/mybb
that referenced
this pull request
Mar 23, 2019
* Initial Cleanup and Main Template Conversion [WIP] * report_thanks * report_thanks * Errors report_error_nomodal, * report_duplicate * Report Reason report_reason, report_reasons * Separated `nomodal` Content ...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template. * Adjust Alignment * Remove unused assignment * Remove Template Cache List
euantorano
pushed a commit
to euantorano/mybb
that referenced
this pull request
Mar 23, 2019
* Initial Cleanup and Main Template Conversion [WIP] * report_thanks * report_thanks * Errors report_error_nomodal, * report_duplicate * Report Reason report_reason, report_reasons * Separated `nomodal` Content ...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template. * Adjust Alignment * Remove unused assignment * Remove Template Cache List
euantorano
pushed a commit
that referenced
this pull request
Jun 2, 2019
* Initial Cleanup and Main Template Conversion [WIP] * report_thanks * report_thanks * Errors report_error_nomodal, * report_duplicate * Report Reason report_reason, report_reasons * Separated `nomodal` Content ...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template. * Adjust Alignment * Remove unused assignment * Remove Template Cache List
euantorano
pushed a commit
that referenced
this pull request
Jun 2, 2019
* Initial Cleanup and Main Template Conversion [WIP] * report_thanks * report_thanks * Errors report_error_nomodal, * report_duplicate * Report Reason report_reason, report_reasons * Separated `nomodal` Content ...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template. * Adjust Alignment * Remove unused assignment * Remove Template Cache List
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Ready for testing]
For #2972
Templates: