Remove wrong-context canbeinvisible conditions (#4803)

forumdisplay.php

@@ -307,7 +307,7 @@
 		{
 			$doneusers[$user['uid']] = $user['time'];
 			++$membercount;
-			if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)
+			if($user['invisible'] == 1)
 			{
 				$invisiblemark = "*";
 				++$inviscount;

inc/functions_online.php

@@ -1144,7 +1144,7 @@ function build_wol_row($user)
 		if($user['invisible'] != 1 || $mybb->usergroup['canviewwolinvis'] == 1 || $user['uid'] == $mybb->user['uid'])
 		{
 			// Append an invisible mark if the user is invisible
-			if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)
+			if($user['invisible'] == 1)
 			{
 				$invisible_mark = "*";
 			}

index.php

@@ -116,15 +116,15 @@
 			if(empty($doneusers[$user['uid']]) || $doneusers[$user['uid']] < $user['time'])
 			{
 				// If the user is logged in anonymously, update the count for that.
-				if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)
+				if($user['invisible'] == 1)
 				{
 					++$anoncount;
 				}
 				++$membercount;
 				if($user['invisible'] != 1 || $mybb->usergroup['canviewwolinvis'] == 1 || $user['uid'] == $mybb->user['uid'])
 				{
 					// If this usergroup can see anonymously logged-in users, mark them.
-					if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)
+					if($user['invisible'] == 1)
 					{
 						$invisiblemark = '*';
 					}

online.php

@@ -75,7 +75,7 @@
 	while($online = $db->fetch_array($query))
 	{
 		$invisiblemark = '';
-		if($online['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)
+		if($online['invisible'] == 1)
 		{
 			$invisiblemark = "*";
 		}

showthread.php

@@ -1589,7 +1589,7 @@
 				$doneusers[$user['uid']] = $user['time'];
 
 				$invisiblemark = '';
-				if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)
+				if($user['invisible'] == 1)
 				{
 					$invisiblemark = "*";
 					++$inviscount;