Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce linter (flake8) #496

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce linter (flake8) #496

wants to merge 3 commits into from

Conversation

shion1305
Copy link

@shion1305 shion1305 commented Jan 27, 2024 •
edited

Resolves: #487
This PR introduces linter, flake8.
I chose the appropriate configuration for GHunt, described as followings.

  • Exclude: *_pb2.py
  • Ignore Rules: F403 , F405 , F541
  • max-line-length=150

@shion1305 shion1305 marked this pull request as draft January 27, 2024 18:57
@shion1305 shion1305 force-pushed the shion/linter-ci branch 5 times, most recently from 799246f to 4c19e59 Compare January 27, 2024 19:09
@shion1305 shion1305 marked this pull request as ready for review January 27, 2024 19:20
@ignaigna
Copy link

why not use ruff? its faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggestion] Introduce linter, integrate as GitHub Actions.
2 participants
@shion1305 @ignaigna