Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visionOS #1333

Merged
merged 32 commits into from Apr 6, 2024
Merged

visionOS #1333

merged 32 commits into from Apr 6, 2024

Conversation

RomanPodymov
Copy link
Collaborator

@RomanPodymov RomanPodymov commented Feb 13, 2024 •
edited

Hello.
Thank you for PromiseKit.
visionOS support.
Fix #1326.

@RomanPodymov RomanPodymov marked this pull request as draft February 13, 2024 05:36
@mxcl
Copy link
Owner

mxcl commented Feb 14, 2024

Nice job. Approved. We should drop Carthage officially probs. Does anyone use it?

@mxcl
Copy link
Owner

mxcl commented Feb 14, 2024

Undraft it when ready

@RomanPodymov
Copy link
Collaborator Author

Hello @mxcl
Probably someone is still using PromiseKit + Carthage since PromiseKit is an old and popular library. But we can at least disable Carthage CI for now.

@RomanPodymov RomanPodymov marked this pull request as ready for review February 15, 2024 12:37
@RomanPodymov
Copy link
Collaborator Author

Hello @mxcl
It's ready for review.

@RomanPodymov RomanPodymov merged commit a3b4668 into mxcl:master Apr 6, 2024
17 checks passed
@RomanPodymov RomanPodymov deleted the feature/visionos branch April 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl Awaiting requested review from mxcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of visionOS
2 participants
@RomanPodymov @mxcl