Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Translator Plugin to Differentiate Private Messages from Public Channels #2689

Conversation

Rick-Sanchez-C
Copy link

Overview

This pull request enhances the Translator plugin by adding functionality to differentiate between private messages (DMs) and public channels when configuring translation settings.

Changes Made

  • Added differentiation logic:
    • Updated getLanguageChoice function to check if the channel is a private message and retrieve the language choice accordingly.
    • Modified saveLanguageChoice function to save settings separately for private messages and guild channels.
  • Updated UI components:
    • Ensured the translation button and settings panel reflect changes based on the type of channel.

Testing

  • Tested the plugin with:
    • Direct messages (DMs)
    • Group DMs
    • Public channels in a guild
  • Verified that the translation settings are correctly applied and stored for each type of channel.

Motivation

These changes aim to improve user experience by allowing distinct translation settings for private and public conversations, thereby providing more granular control over the plugin's functionality.

@mwittrien
Copy link
Owner

What exactly does this change?

You can already change the language choices on a server and channel level, why add a DM check?

@mwittrien
Copy link
Owner

No response, closed.

@mwittrien mwittrien closed this May 25, 2024
Repository owner locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants