Merge pull request #299 from mwaskom/fix_lmplot_legend

Don't show lmplot legend when hue in [row, col]
mwaskom · Sep 21, 2014 · 34957a5 · 34957a5
2 parents ecdf9ef + bebfa76
commit 34957a5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/doc/releases/v0.5.0.txt b/doc/releases/v0.5.0.txt
@@ -16,6 +16,8 @@ Color palettes
 Bug fixes
 ~~~~~~~~~
 
+- Fixed a bug where :func:`lmplot` would show a legend when the hue variable was also used on either the rows or columns (making the legend redundant).
+
 - Fixed a bug in :class:`PairGrid` that gave incorrect results (or a crash) when the input DataFrame has a non-default index.
 
 - Fixed a bug in :class:`PairGrid` where passing columns with a date-like datatype raised an exception.

diff --git a/seaborn/linearmodels.py b/seaborn/linearmodels.py
@@ -771,7 +771,7 @@ def lmplot(x, y, data, hue=None, col=None, row=None, palette=None,
     facets.map_dataframe(regplot, x, y, **kwargs)
 
     # Add a legend
-    if hue is not None and legend:
+    if legend and (hue is not None) and (hue not in [col, row]):
         facets.add_legend()
     return facets
 

diff --git a/seaborn/tests/test_linearmodels.py b/seaborn/tests/test_linearmodels.py
@@ -932,6 +932,11 @@ def test_lmplot_facets(self):
 
         plt.close("all")
 
+    def test_lmplot_hue_col_nolegend(self):
+
+        g = lm.lmplot("x", "y", data=self.df, col="h", hue="h")
+        nt.assert_is(g._legend, None)
+
     def test_lmplot_scatter_kws(self):
 
         g = lm.lmplot("x", "y", hue="h", data=self.df, ci=None)