Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board class and improvements #14

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

melmols
Copy link
Collaborator

@melmols melmols commented Apr 30, 2021

  • Separated into board class with NamedTuple with it's respective test cases: the next PRs will have similar changes, where the classes will be divided per functionality and components (e.g ticket creation class, layer export class etc) this helps with flexibility and scalability.

Screenshot 2021-04-30 at 12 13 59

  • Added a "ticket exists" condition to check whether a ticket exists before creating to prevent duplication.
  • Improvements: Added tracebacks (stderr) because stderr is one of the command output as stdout, which is logged anywhere by default / Formatting with f strings for increased consistency / Added http.status for readability instead of hardcoded status code. Also updated readme and requirements and added black and poetry.

@melmols melmols requested a review from mvelazc0 April 30, 2021 22:59
@melmols melmols changed the base branch from master to dev April 30, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant