[DROOLS-7540] Coercion from Interger literal to BigDecimal bind variable #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Sep 6, 2023
Comment on lines
+42
to
+49
| if (type == Object.class || type == null) { | ||
| // IndexVariableResolver doesn't know the original declared type, so cannot deal with polymorphism | ||
| // Just accept the value | ||
| vars[indexPos] = value; | ||
| } else { | ||
| // Coerce numeric types | ||
| vars[indexPos] = handleTypeCoercion(type, value); | ||
| } |
There was a problem hiding this comment.
This PR makes IndexVariableResolver able to coerce numeric values.
Note that IndexVariableResolver doesn't know the original declared type, so cannot deal with polymorphism, so it just accept the value (= original behavior).
If we want to do type check, we would need to change SimpleVariableSpaceModel to store type information (or maybe creating a new class e.g. TypedVariableSpaceModel) . So we would also need to change drools side. I wonder if we want to do such a large change for this issue.
There was a problem hiding this comment.
I totally agree on the fact that it doesn't make any sense to develop any change bigger than this for such a corner case issue. Good job!
mariofusco
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DROOLS-7540
This is a fix to solve test cases in https://github.com/kiegroup/drools/pull/5498
Drools uses
SimpleVariableSpaceModelto createIndexedVariableResolverFactory. What this PR does areSimpleSTValueResolverinstead ofSimpleValueResolverto enable coercionIndexVariableResolverto enable coercion