Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-7456 update ASM and using shading in maven build #330

Merged
merged 1 commit into from Jun 1, 2023

Conversation

tarilabs
Copy link
Contributor

  • Update version of ASM (so MVEL to be compatible with more recent bytecode)
  • Avoid the "shading manually"
  • Use standard maven-shade-plugin
  • Suggest moving to next minor version to signify the change in the ASM (and shading strategy)

If there were any concern about final size of artifact using the shade plugin in compared to manually I believe it's irrelavant if compared to the current master default branch baseline (considering as well the ASM update), accounting for ~1.3%:

this PR:
-rw-r--r--  1 mmortari  staff  826384 May 31 14:21 target/mvel2-2.5.0-SNAPSHOT.jar

baseline (current master default branch):
-rw-r--r--  1 mmortari  staff  815481 May 31 14:22 target/mvel2-2.4.16-SNAPSHOT.jar

826384 / 815481
= 1.01337002334
→ ~1.3%

@jdimeo
Copy link

jdimeo commented Mar 27, 2024

This broke the proper construction of the sources .jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants