Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle error and other edge cases. Handle offline state better. #135

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: handle error and other edge cases. Handle offline state better. #135

merged 2 commits into from
Apr 18, 2024

Conversation

cjpillsbury
Copy link
Contributor

@cjpillsbury cjpillsbury commented Apr 18, 2024 •
edited

  • Initializes offline state accurately on construction
  • Expose offline (readonly) state
  • Reset progress state (and notify change via event) on errors
  • Account for non-status based errors
  • Update types/reduce type assumptions based on refactors described above.

@cjpillsbury cjpillsbury requested a review from a team as a code owner April 18, 2024 18:01
luwes
luwes approved these changes Apr 18, 2024
View reviewed changes
Copy link

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cjpillsbury cjpillsbury merged commit 2181381 into muxinc:master Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwes luwes luwes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjpillsbury @luwes