Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mupen64plus appdata #49

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 29 additions & 0 deletions data/org.mupen64plus.Mupen64Plus.appdata.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
<component type="desktop">
<id>org.mupen64plus.Mupen64Plus</id>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing <launchable type="desktop-id">org.mupen64plus.Mupen64Plus.desktop</launchable>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch

<launchable type="desktop-id">org.mupen64plus.Mupen64Plus</launchable>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<launchable type="desktop-id">org.mupen64plus.Mupen64Plus</launchable>
<launchable type="desktop-id">org.mupen64plus.Mupen64Plus.desktop</launchable>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for the catch

<name>Mupen64Plus</name>
<summary>Nintendo 64 Emulator</summary>
<metadata_license>CC-BY-SA-3.0</metadata_license>
<project_license>GPL-2.0+</project_license>
<description>
<p>
Mupen64plus is a Nintendo 64 Emulator.
This package includes all the plug-ins.
</p>
</description>
<url type="homepage">https://mupen64plus.org/</url>
<url type="help">https://mupen64plus.org/docs/</url>
<url type="bugtracker">https://github.com/mupen64plus/mupen64plus-user-issues/issues</url>
<url type="donation">https://www.paypal.com/webapps/shoppingcart?flowlogging_id=59a5b20d47d74&mfid=1541895691620_59a5b20d47d74</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you find this PayPal link? I don’t see it on the homepage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's linked from here (looks like an old site):

http://mupen64.emulation64.com/

Should it be removed from this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; that PayPal link is for Hacktarux who as far as I know hasn’t been involved for years.

<screenshots>
<screenshot type="default">
<image>https://screenshots.debian.net/screenshots/000/010/356/large.png</image>
<caption>Command line interface help out</caption>
</screenshot>
</screenshots>
<releases>
<release date="2015-04-26" version="2.5"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is upstream still developed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's been a very long time since they've had a release.

(It looks like they broke up their source into a bunch of different modules in going to git hub, and have updated some of the modules, but not the "core")

</releases>
<developer_name>Mupen64Plus</developer_name>
</component>
7 changes: 7 additions & 0 deletions projects/unix/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ endif
ifeq ($(ICONSDIR),)
ICONSDIR := $(PREFIX)/share/icons/hicolor
endif
ifeq ($(ASDIR),)
ASDIR := $(PREFIX)/share/metainfo
endif

SRCDIR = ../../src
OBJDIR = _obj$(POSTFIX)
Expand Down Expand Up @@ -280,6 +283,7 @@ targets:
@echo " MANDIR=path == path to install mupen64plus manual page (default: PREFIX/share/man)"
@echo " APPSDIR=path == path to install desktop file (default: PREFIX/share/applications)"
@echo " ICONSDIR=path == path to install icon files (default: PREFIX/share/icons/hicolor)"
@echo " ASDIR=path == path to install appstream data files (default: PREFIX/share/metainfo)"
@echo " DESTDIR=path == path to prepend to all installation paths (only for packagers)"
@echo " Debugging Options:"
@echo " DEBUG=1 == add debugging symbols to application binary"
Expand All @@ -303,13 +307,16 @@ install: $(TARGET)
$(INSTALL) -m 0644 ../../data/icons/48x48/apps/mupen64plus.png "$(DESTDIR)$(ICONSDIR)/48x48/apps"
$(INSTALL) -d "$(DESTDIR)$(ICONSDIR)/scalable/apps"
$(INSTALL) -m 0644 ../../data/icons/scalable/apps/mupen64plus.svg "$(DESTDIR)$(ICONSDIR)/scalable/apps"
$(INSTALL) -d "$(DESTDIR)$(ASDIR)"
$(INSTALL) -m 0644 ../../data/org.mupen64plus.Mupen64Plus.appdata.xml "$(DESTDIR)$(ASDIR)"


uninstall:
$(RM) "$(DESTDIR)$(BINDIR)/$(TARGET)" "$(DESTDIR)$(MANDIR)/man6/mupen64plus.6"
$(RM) "$(DESTDIR)$(APPSDIR)/mupen64plus.desktop"
$(RM) "$(DESTDIR)$(ICONSDIR)/48x48/apps/mupen64plus.png"
$(RM) "$(DESTDIR)$(ICONSDIR)/scalable/apps/mupen64plus.svg"
$(RM) "$(DESTDIR)$(ASDIR)/org.mupen64plus.Mupen64Plus.appdata.xml"


# build dependency files
Expand Down