Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More autocfg pads #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bsmiles32
Copy link
Member

I went through the google code issue tracker and ControllerSetup comment section to upstream user-provided gamepad configurations. As I don't own any of the device mentioned, I cannot test if those settings are correct or not.

If this PR gets merged, issues 426, 601 and 629 from the google code issue tracker can be closed.

Reported by mkhom...@googlemail.com in google code  issue tracker (601).
Note: user reports that Start button "is not running correct" and in
that case button(7) [ie Right Axis button] could be used as a workaround.
Reported by ale...@gmail.com in google code issue tracker (629).
Yug...@gmail.com also reported that Huija prefix was not necessary for
him, that's why I added both descriptors.
Reported lestbria...@gmail.com in google code issue tracker (426).
Reported by phill.wa...@gmail.com in ControllerSetup page comments.
Reported by ondra@ondrovo.com in ControllerSetup page comments.
Reported by mick.sau...@gmail.com in ControllerSetup page comments.
@richard42
Copy link
Member

The way that the joystick name matching code works, is that it subdivides the name into words separated by spaces, and then it searches for each word in each candidate section of the InputAutoCfg.ini file. A couple of artifacts of this process are that all of the extra spaces in a joystick name like this are unnecessary:

[Honey Bee AIRFLO ]

Also, these 2 sections are effectively the same:

[USB Gamepad]
...
; Trust USB Gamepad GM-1520T
[USB Gamepad ]

In this case, the second section will never be used because anything that would match this would also match the first section.

@bsmiles32
Copy link
Member Author

I didn't know about that subtlety.
So for "Honey Bee AIRFLO" I can remove the extra spaces.
However there is a conflict for the two "USB Gamepad" and it seems that I cannot have both with the current matching code. What would you suggest :

  • Choose one over the other ?
  • Choose none as the name is pretty generic ?
  • Change the matching code in order to remove that limitation ?

@richard42
Copy link
Member

I tend to think that it's a defect in SDL (or the USB device drivers) to have such generic device names. I would recommend just picking one of the configurations for the USB Gamepad joystick.

@Zero86Sk
Copy link
Contributor

Hello I am new to git but i would like to contribute

I am using a [Xbox Wireless Adapter for Windows]
so Xbox One Wireless reciever, but not sure how to do that.

Mupen (M64py) dosnt recognise and save my controler

@helviojr
Copy link

      Hello I am new to git but i would like to contribute

I am using a [Xbox Wireless Adapter for Windows]
so Xbox One Wireless reciever, but not sure how to do that.
Mupen (M64py) dosnt recognise and save my controler

Xbox One wireless controllers (at least on Win 10) are recognized as [Controller (Xbox One For Windows)]. Autoconfig.ini is already patched on current master branch for those controllers and is working ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants