New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minizip #1074

Merged

richard42 merged 1 commit into mupen64plus:master from loganmc10:zip

May 7, 2024

Member

loganmc10 commented May 2, 2024

Minizip no longers builds for me in the latest versions of GCC

/__w/simple64/simple64/mupen64plus-core/subprojects/minizip/zip.c:1249:28: error: assignment to 'const long unsigned int *' from incompatible pointer type 'const uint32_t *' {aka 'const unsigned int *'} [-Wincompatible-pointer-types]
 1249 |         zi->ci.pcrc_32_tab = get_crc_table();

I've updated minizip using the latest sources from here:
https://github.com/madler/zlib/tree/master/contrib/minizip


          Update minizip

e3b9f90

Contributor

Jj0YzL5nvJ commented May 2, 2024

I think it's worth mentioning the potential vulnerability this fixes: madler/zlib#868
Personally I was waiting for 1.3.2...

Note: MSYS2 is currently failing due to the missing vulkan-headers dependencies, I will send an upgrade for CI/CD soon...

richard42 merged commit 792e360 into mupen64plus:master

8 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment