RSP opcode fixes #1061
Merged
RSP opcode fixes #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Matt Pharoah <mtpharoah@gmail.com>
Co-Authored-By: Matt Pharoah <mtpharoah@gmail.com>
…e time Co-Authored-By: Matt Pharoah <mtpharoah@gmail.com>
Co-Authored-By: Matt Pharoah <mtpharoah@gmail.com>
|
@mpharoah Anything missing here? |
|
Looks good |
mpharoah
approved these changes
Jan 26, 2024
GhostlyDark
commented
Jan 27, 2024
loganmc10
suggested changes
Jan 27, 2024
|
Thanks all for your work and the reviews. This looks good to me. Can I merge ? |
|
It can be merged, it shouldn't cause any regressions. I should mention however that there are follow-up changes that aren't as straightforward to port over, but those could be part of another PR. |
|
Thanks ! I also agree about putting those in a separated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from:
https://gitlab.com/parallel-launcher/parallel-n64/-/commit/4f7b8a6081f7d02bac26e041f1baf5d5e91875f2
https://gitlab.com/parallel-launcher/parallel-n64/-/commit/3052f79c162a232301fdf725038f813c1ec02edb
https://gitlab.com/parallel-launcher/parallel-n64/-/commit/f379d606e4dd000b72ae90273a1b1874b51f5307
https://gitlab.com/parallel-launcher/parallel-n64/-/commit/07ce4bfd7528cde68939ad2ce1a06c2c7029ec15#06a9a5c035040370b6d9d811526d9586179b3176_52_52
Reference:
libretro/parallel-rsp#10