Safari tests fix #1535
Draft
Safari tests fix #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @aguspina help would be valuable here 😄. |
|
This may be the most suffocating, heart-taking, demoralizing PR draft we have ever had in the platform 😞
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplish nothing.
I've tested quite a lot of things trying to fix safari tests and I didn't succeeded.
It seems that session is not being deleted, and even when no user should be logged in,
johndoe@test.comappears as logged in which is our default uid used in Omniauth mock.I've tried making options explicit, as you'll see in the commits, but it didn't work.
I've trying updating safari and macOs versions but that didn't work neither.
I've left only safari tests in order to make them run faster, that change shouldn't be included if tests are finally fixed