Offline evaluation support #1434
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flbulgarelli
commented
Jul 27, 2020
| @@ -5,7 +5,8 @@ ruby '~> 2.3' | |||
|
|
|||
| gem 'puma' | |||
|
|
|||
| gem 'mumuki-domain', github: 'mumuki/mumuki-domain' | |||
| gem 'mumuki-domain', github: 'mumuki/mumuki-domain', branch: 'feature-cumparsita' | |||
There was a problem hiding this comment.
This line only adds offline tests. We should merge them instead
| @@ -5,7 +5,8 @@ ruby '~> 2.3' | |||
|
|
|||
| gem 'puma' | |||
|
|
|||
| gem 'mumuki-domain', github: 'mumuki/mumuki-domain' | |||
| gem 'mumuki-domain', github: 'mumuki/mumuki-domain', branch: 'feature-cumparsita' | |||
| gem 'mulangjs', path: '../mulang/ghcjslib/gem' | |||
There was a problem hiding this comment.
Not necessary in the first iteration
| @@ -196,6 +196,8 @@ which are granted to be safe and stable. | |||
| * `setUpDeleteFiles` | |||
| * `setUpDeleteFile` | |||
| * `updateButtonsVisibility` | |||
| * `mumuki.registerLocalTestRunner` | |||
| * `mumuki.registerLocalExpectationsRunner` | |||
There was a problem hiding this comment.
OK. Perhaps could be namespaced into mumuki.local
This steps may not always be necessary for local evaluation. They should be documented
| @@ -204,9 +206,7 @@ which are granted to be safe and stable. | |||
| { | |||
| "status": "failed", | |||
| "guide_finished_by_solution": false, | |||
| "class_for_progress_list_item":"progress-list-item text-center danger active", | |||
| "html":"...", | |||
There was a problem hiding this comment.
Although this is not strictly necessary for a first iteration, it has a lot of sense
| //= require rails-ujs | ||
| //= require turbolinks |
| data: solution | ||
| }); | ||
| return $.ajax(request); | ||
| } |
There was a problem hiding this comment.
Local evaluation + local progress + local sync
| result.html = result.html || mumuki.renderCorollaryHtml(status, exercise); | ||
| } catch (e) { | ||
| console.log(`[Mumuki::Laboratory::Bridge] pre-rendering failed ${e}`); | ||
| throw e; |
| editor.getDoc().setValue(content); | ||
| }); | ||
| } | ||
|
|
| @@ -7,7 +7,7 @@ mumuki.load(function () { | |||
| url: $(this).data('confirmation-url'), | |||
| xhrFields: {withCredentials: true}, | |||
| success: function(data){ | |||
| mumuki.updateProgressBarAndShowModal(data); | |||
| mumuki.updateCurrentExerciseProgressBarAndShowModal(data); | |||
There was a problem hiding this comment.
Rollback. Heavily backward incompatible
flbulgarelli
commented
Aug 5, 2020
| Laboratory.prototype = { | ||
|
|
||
| (() => { | ||
| class Laboratory { |
flbulgarelli
commented
Aug 5, 2020
| mumuki.load(() => { | ||
| // Set global currentExerciseId | ||
| const $muExerciseId = $('#mu-exercise-id')[0]; | ||
| const $muExerciseResource = $('#mu-exercise-resource')[0]; |
There was a problem hiding this comment.
Partially done in #1443
This was referenced Aug 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft is just a notebook, based on an old unmerged feature of offline suppport.
It contains comments and references to the actual PRs that merge this behaviour:
See: