-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SERVICES-2370] Pairs query pagination, sorting and filtering #1347
Merged
mad2sm0key
merged 14 commits into
development
from
SERVICES-2370-pairs-query-pagination-sorting-and-filtering
May 27, 2024
Merged
[SERVICES-2370] Pairs query pagination, sorting and filtering #1347
mad2sm0key
merged 14 commits into
development
from
SERVICES-2370-pairs-query-pagination-sorting-and-filtering
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…370-pairs-query-pagination-sorting-and-filtering
Tests 🟢
|
…sorting-and-filtering
- separate filter args for the 2 pairs queries - handle case when pagination argument is undefined
- create PairMetadataBuilder class to handle filtering - extract filtering methods in separate service
mad2sm0key
changed the base branch from
SERVICES-2331-pairs-query-extra-fields
to
development
May 22, 2024 14:10
claudiulataretu
approved these changes
May 22, 2024
claudiulataretu
requested changes
May 22, 2024
- renamed 'filterablePairs' query to 'filteredPairs' - remove unused imports - made all methods in Pairs filtering service return a promise for unified usage - moved PageData to common module
- update wording on deprecation reason and pagination exception message
claudiulataretu
approved these changes
May 24, 2024
bogdan-rosianu
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Proposed Changes
filterablePairs
query that follows the GraphQL "Connections" specificationHow to test