-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SERVICES-2331] Pairs query extra fields #1346
[SERVICES-2331] Pairs query extra fields #1346
Conversation
- add fields and resolvers - add compute methods
- add field resolver and compute trades count using elastic search
- add field resolver and compute field using data from mxapi
- make a single query that targets both swap functions in 1 request
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1346 +/- ##
===============================================
- Coverage 56.34% 55.86% -0.49%
===============================================
Files 236 238 +2
Lines 7945 8178 +233
Branches 534 562 +28
===============================================
+ Hits 4477 4569 +92
- Misses 3013 3126 +113
- Partials 455 483 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- use FarmAbiV2 directly instead of using FarmAbiFactory - remove unnecessary mock for farm abi factory and update unit test - add extra constraint for transaction status on ES query - update cache warmer Cron expression to "EVERY_MINUTE"
Reasoning
pairs
queryProposed Changes
PairModel
:hasFarms
,hasDualFarms
,tradesCount
,deployedAt
How to test