chain simulator force change of epoch
#6173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
previously approved these changes
May 16, 2024
|
|
||
| epoch := s.nodes[core.MetachainShardId].GetProcessComponents().EpochStartTrigger().Epoch() | ||
|
|
||
| return s.GenerateBlocksUntilEpochIsReached(int32(epoch + 1)) |
| require.Nil(t, err) | ||
|
|
||
| err = chainSimulator.ForceChangeOfEpoch() | ||
| require.Nil(t, err) |
There was a problem hiding this comment.
maybe add an assert here that the epoch is 5 4?
iulianpascalau
previously approved these changes
May 16, 2024
sstanculeanu
previously approved these changes
May 20, 2024
| @@ -278,6 +278,22 @@ func (s *simulator) incrementRoundOnAllValidators() { | |||
| } | |||
| } | |||
|
|
|||
| // ForceChangeOfEpoch will force the change of current epoch | |||
| // This method will call the epoch change trigger and generate block till a new epoch is reached | |||
There was a problem hiding this comment.
Suggested change
| // This method will call the epoch change trigger and generate block till a new epoch is reached | |
| // This method will call the epoch change trigger and generate blocks till a new epoch is reached |
miiu96
changed the base branch from
rc/v1.7.next1
to
feat/chain-simulator-improvments
miiu96
dismissed stale reviews from sstanculeanu and iulianpascalau
The base branch was changed.
iulianpascalau
approved these changes
May 20, 2024
sstanculeanu
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?