Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup proposal misses #6161

Open
wants to merge 3 commits into
base: rc/v1.7.next1
Choose a base branch
from
Open

cleanup proposal misses #6161

wants to merge 3 commits into from

Conversation

AdoAdoAdo
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

gabi-vuls
gabi-vuls previously approved these changes May 15, 2024
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> unjail-cleanup-c91444b32e

--- Specific errors ---

block hash does not match 1119
wrong nonce in block 575
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 349
Nr. of new ERRORS: 0
Nr. of new WARNS: 9
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

danidrasovean
danidrasovean previously approved these changes May 15, 2024
Copy link

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested jail-unjail scenarios.

@@ -341,6 +342,7 @@ func (stp *stakingToPeer) updatePeerState(
if account.GetTempRating() < stp.unJailRating {
log.Debug("node is unJailed, setting temp rating to start rating", "blsKey", blsPubKey)
account.SetTempRating(stp.unJailRating)
account.SetConsecutiveProposerMisses(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag ?

Copy link
Contributor Author

@AdoAdoAdo AdoAdoAdo May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet checked with importdb to see if we need the activation flag, but most probably will need to add.

@AdoAdoAdo AdoAdoAdo dismissed stale reviews from danidrasovean and gabi-vuls via 288012b May 21, 2024 11:07
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.7.11-f7efd0fc48 -> unjail-cleanup-288012b6e1

--- Specific errors ---

block hash does not match 1741
wrong nonce in block 915
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 0
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants