Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sovereign bridge scripts #6155

Merged
merged 8 commits into from
May 17, 2024
Merged

Sovereign bridge scripts #6155

merged 8 commits into from
May 17, 2024

Conversation

axenteoctavian
Copy link

Reasoning behind the pull request

  • Sovereign bridge scripts

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian marked this pull request as ready for review May 10, 2024 14:14
sasurobert
sasurobert previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sasurobert sasurobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need defined explanation for every single public function. maybe chatGPT can help on starting a structure for it, and creating documentation for scripts/variables/configs.

@mariusmihaic mariusmihaic self-requested a review May 16, 2024 09:32
mariusmihaic
mariusmihaic reviewed May 16, 2024
View reviewed changes
scripts/testnet/sovereignBridge/config/common.snippets.sh Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/config/common.snippets.sh Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/config/common.snippets.sh Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/config/common.snippets.sh Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/config/configs.cfg Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/pyScripts/bridge_service.py Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/pyScripts/genesis_contract.py Show resolved Hide resolved
scripts/testnet/sovereignBridge/pyScripts/next_contract.py Outdated Show resolved Hide resolved
scripts/testnet/sovereignBridge/pyScripts/notifier_round.py Show resolved Hide resolved
scripts/testnet/sovereignBridge/pyScripts/update_toml.py Outdated Show resolved Hide resolved
mariusmihaic
mariusmihaic reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@mariusmihaic mariusmihaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please check the unresolved comments

@axenteoctavian axenteoctavian merged commit f3f8e6a into feat/chain-go-sdk May 17, 2024
4 checks passed
@axenteoctavian axenteoctavian deleted the sovereign-bridge-scripts branch May 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@mariusmihaic mariusmihaic mariusmihaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axenteoctavian @sasurobert @mariusmihaic