[sovereign] Add factory for NodesSetupChecker to override it easily. #6143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
We need to override the NodesSetupChecker easily for a Sovereign Chain from the
sovereignNodeRunner.go
file. This way we can havemx-chain-go
as a dependency of a Sovereign Chain GO project and not have to fork the code.Currently this can be overwritten by implementing a custom
managedProcessComponents
andprocessComponentsFactory
, but theprocessComponentsFactory
Create
method has a lot of logic that we would not want to maintain, hence we need an easier way to override the NodesSetupCheckerProposed changes
Added a NodesSetupCheckerFactory and a NodeSetupChecker interface to allow easier customization.
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?