Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Add factory for NodesSetupChecker to override it easily. #6143

Draft
wants to merge 1 commit into
base: feat/chain-go-sdk
Choose a base branch
from

Conversation

raress96
Copy link

Reasoning behind the pull request

We need to override the NodesSetupChecker easily for a Sovereign Chain from the sovereignNodeRunner.go file. This way we can have mx-chain-go as a dependency of a Sovereign Chain GO project and not have to fork the code.

Currently this can be overwritten by implementing a custom managedProcessComponents and processComponentsFactory, but the processComponentsFactory Create method has a lot of logic that we would not want to maintain, hence we need an easier way to override the NodesSetupChecker

Proposed changes

Added a NodesSetupCheckerFactory and a NodeSetupChecker interface to allow easier customization.

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant