Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate vm improve 1.5.5 #6139

Merged
merged 20 commits into from May 9, 2024
Merged

Conversation

sasurobert
Copy link
Contributor

Reasoning behind the pull request

Enable more opcodes and options for developers.

Proposed changes

Integrate new crypto endpoints - BLS MultiSig, Secp256R1
Integrate new Opcodes for Relayer, OriginalCaller
Integrate TransferAndExecuteByUser for SovereignChains
Integrate EGLD in MultiTransfer

Testing procedure

System test every aspect noted before.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-requested a review April 26, 2024 07:51
common/constants.go Outdated Show resolved Hide resolved
common/enablers/enableEpochsHandler_test.go Show resolved Hide resolved
config/tomlConfig_test.go Outdated Show resolved Hide resolved
factory/api/apiResolverFactory_test.go Outdated Show resolved Hide resolved
integrationTests/vm/txsFee/apiTransactionEvaluator_test.go Outdated Show resolved Hide resolved
process/errors.go Outdated Show resolved Hide resolved

_, _ = vm.CreateAccount(testContext.Accounts, sndAddr, 0, senderBalance)

tx := vm.CreateTransaction(0, big.NewInt(0), sndAddr, scAddress, gasPrice, gasLimit, []byte("increment"))

res, err := testContext.TxCostHandler.ComputeTransactionGasLimit(tx)
require.Nil(t, err)
require.Equal(t, uint64(418), res.GasUnits)
fmt.Println(res.GasUnits)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this print.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -74,6 +75,14 @@ func (uas *UserAccountStub) AddToBalance(value *big.Int) error {
return nil
}

// SubFromBalance -
func (uas *UserAccountStub) SubFromBalance(value *big.Int) error {
if uas.AddToBalanceCalled != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SubFromBalanceCalled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mariusmihaic
mariusmihaic previously approved these changes Apr 29, 2024
gabi-vuls
gabi-vuls previously approved these changes Apr 30, 2024
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> integrate-vm-improve-1.5.5-e26260c87e

--- Specific errors ---

block hash does not match 401
wrong nonce in block 291
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 230
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 78.81%. Comparing base (de374b5) to head (c00c31f).
Report is 129 commits behind head on rc/v1.7.next1.

Files Patch % Lines
common/enablers/enableEpochsHandler.go 0.00% 6 Missing ⚠️
process/factory/shard/vmContainerFactory.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.7.next1    #6139      +/-   ##
=================================================
+ Coverage          78.74%   78.81%   +0.07%     
=================================================
  Files                752      752              
  Lines              97976    98368     +392     
=================================================
+ Hits               77153    77532     +379     
- Misses             15584    15598      +14     
+ Partials            5239     5238       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sasurobert sasurobert merged commit 13855e3 into rc/v1.7.next1 May 9, 2024
9 of 10 checks passed
@sasurobert sasurobert deleted the integrate-vm-improve-1.5.5 branch May 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants