Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/esdt prefix #6137

Open
wants to merge 17 commits into
base: rc/v1.7.next1
Choose a base branch
from
Open

Feat/esdt prefix #6137

wants to merge 17 commits into from
+415 −32

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Apr 23, 2024 •
edited

Reasoning behind the pull request

  • Added possibility to issue tokens with prefix(which will be followed by - separator)
  • Each prefix should have max 4 characters (lower and alphanumeric only)
  • In cmd/node/config/systemSmartContractsConfig.toml:
[ESDTSystemSCConfig]
    BaseIssuingCost = "5000000000000000000" #5 eGLD
    OwnerAddress = "erd1fpkcgel4gcmh8zqqdt043yfcn5tyx8373kg6q2qmkxzu4dqamc0swts65c"
    ESDTPrefix = ""

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

mariusmihaic and others added 15 commits March 22, 2024 12:06
@mariusmihaic mariusmihaic self-assigned this Apr 23, 2024
mariusmihaic and others added 2 commits May 15, 2024 14:28
@mariusmihaic
Merge branch 'rc/v1.7.next1' into merge-rc-1-7-next-into-feat-esdt-pr…
733cceb 
…efix

# Conflicts:
#	errors/errors.go
@mariusmihaic
Merge pull request #6169 from multiversx/merge-rc-1-7-next-into-feat-…
fde5993 
…esdt-prefix

Merge rc 1 7 next into feat esdt prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mariusmihaic mariusmihaic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mariusmihaic