Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added map support for over writable configs #6116

Open
wants to merge 4 commits into
base: rc/v1.7.next1
Choose a base branch
from

Conversation

axenteoctavian
Copy link

@axenteoctavian axenteoctavian commented Apr 15, 2024

Reasoning behind the pull request

  • Needed support for Map in over writable configs for enableRound.toml
  • also cleaned some stuff in tests

Proposed changes

  • Added support for Map to be overwritten by other map
  • Added tests with real data from a toml file

Testing procedure

  • uncomment and always use OverridableConfigTomlValues in cmd/node/config/prefs.toml
  • test override map with real data from prefs.toml (similar examples in testscommon/toml/overwrite.toml)
  • also test other over-writable values: int/float/bool/struct/slice etc - with good and bad data
  • nodes should start normally with correct values and log what was overridden, otherwise not start

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian marked this pull request as ready for review April 17, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants