Feat/RelayedV3 #5741

sstanculeanu · 2023-11-27T12:39:18Z

Reasoning behind the pull request

relayed tx v3

Proposed changes

implemented relayed tx v3. Now the inner tx is a full tx, held by the parent tx in a new field InnerTransaction
fixed relayed fee on relayed move balance

Testing procedure

standard system test
test relayed v1 and relayed v2 fees for all kind of transactions(failure/refund scenarios to be verified as well)
test relayed v3 transaction execution + fees

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

…s + refactor on relayed tests

…into relayedV3 # Conflicts: # go.mod # go.sum

… to be the same with parent tx sender and removed skip for balance check as it is not needed anymore

Relayed v3

Separate fee handling for inner tx of type move balance

…into feat/relayedv3 # Conflicts: # api/groups/transactionGroup.go # cmd/node/config/enableEpochs.toml # common/enablers/enableEpochsHandler.go # common/enablers/enableEpochsHandler_test.go # common/enablers/epochFlags.go # common/interface.go # config/epochConfig.go # config/tomlConfig_test.go # go.mod # go.sum # integrationTests/multiShard/relayedTx/relayedTx_test.go # integrationTests/vm/txsFee/relayedScDeploy_test.go # node/node.go # process/errors.go # process/transaction/shardProcess_test.go # testscommon/enableEpochsHandlerMock/enableEpochsHandlerStub.go

…dv3_2023.11.27 Merge rc170 into feat relayedv3 2023.11.27

codecov · 2023-11-27T15:31:41Z

Codecov Report

Attention: Patch coverage is 74.23581% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 78.77%. Comparing base (c00c31f) to head (d31d68b).
Report is 88 commits behind head on rc/v1.7.next1.

❗ Current head d31d68b differs from pull request most recent head ab49574. Consider uploading reports for the commit ab49574 to get more accurate results

Files	Patch %	Lines
api/groups/transactionGroup.go	59.82%	44 Missing and 1 partial ⚠️
node/external/transactionAPI/unmarshaller.go	0.00%	2 Missing and 2 partials ⚠️
node/node.go	33.33%	3 Missing and 1 partial ⚠️
process/transaction/shardProcess.go	91.42%	2 Missing and 1 partial ⚠️
process/constants.go	0.00%	2 Missing ⚠️
process/transaction/interceptedTransaction.go	98.00%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           rc/v1.7.next1    #5741      +/-   ##
=================================================
- Coverage          78.81%   78.77%   -0.05%     
=================================================
  Files                752      752              
  Lines              98368    98137     -231     
=================================================
- Hits               77532    77308     -224     
- Misses             15598    15604       +6     
+ Partials            5238     5225      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…into feat/relayedv3 # Conflicts: # common/constants.go # common/enablers/enableEpochsHandler.go # common/enablers/enableEpochsHandler_test.go # config/epochConfig.go # config/tomlConfig_test.go # go.mod # go.sum # node/metrics/metrics_test.go # process/errors.go

…dv3_2024.01.30 Merge rc170 into feat relayedv3 2024.01.30

added api check for recursive relayed v3 + fixed interceptor

…n-go into feat/relayedv3 # Conflicts: # cmd/node/config/enableEpochs.toml # common/constants.go # common/enablers/enableEpochsHandler.go # common/enablers/enableEpochsHandler_test.go # config/epochConfig.go # config/tomlConfig_test.go # genesis/process/shardGenesisBlockCreator.go # go.mod # go.sum # integrationTests/vm/txsFee/multiShard/relayedMoveBalance_test.go # integrationTests/vm/txsFee/relayedBuiltInFunctions_test.go # integrationTests/vm/txsFee/relayedESDT_test.go # integrationTests/vm/txsFee/relayedScCalls_test.go # integrationTests/vm/txsFee/relayedScDeploy_test.go # node/metrics/metrics_test.go # node/node_test.go

…layedv3_2024.03.22 Merge rc17next1 into feat relayedv3 2024.03.22

…n-go into feat/relayedv3 # Conflicts: # common/constants.go # common/enablers/enableEpochsHandler.go # common/enablers/enableEpochsHandler_test.go # config/epochConfig.go # config/tomlConfig_test.go # go.mod # go.sum # integrationTests/multiShard/relayedTx/relayedTxV2_test.go # integrationTests/multiShard/relayedTx/relayedTx_test.go # integrationTests/vm/txsFee/moveBalance_test.go # integrationTests/vm/txsFee/relayedBuiltInFunctions_test.go # integrationTests/vm/txsFee/relayedScCalls_test.go # process/errors.go

…layedv3_2024.05.15 Merge rc17next1 into feat/relayedv3 2024.05.15

sstanculeanu and others added 22 commits September 8, 2023 15:06

new flag for relayed v3

18e8d70

updaet mx-chain-core-go

96203d7

added implementation on processing and interceptor + integration test…

a777fac

…s + refactor on relayed tests

Merge branch 'rc/v1.6.0' of https://github.com/multiversx/mx-chain-go …

913b9c3

…into relayedV3 # Conflicts: # go.mod # go.sum

removed unused method

8d4b90a

finished implementation + fixed all tests

124541c

fixed typo after self review

1608e13

added skip for user tx in tx validator balance check

ad459c0

fixes after first review

f379f31

fixed failing tests

81603cc

added separate fee handling for inner tx of type move balance

34f868d

fixes after review

bd43a15

further fixes after review.. added check for inner tx relayer address…

075b746

… to be the same with parent tx sender and removed skip for balance check as it is not needed anymore

added extra check for relayer address on interceptor + fixed tests

ca23f1b

Merge pull request #5572 from multiversx/relayedV3

34e8ba4

Relayed v3

Merge branch 'feat/relayedv3' into relayed_move_balance

62e4adc

fixes after review

a3014e6

fix tests

ff9f169

further fixes after review + proper fee fix

828e69d

fixed tests when running with race

9f76f80

fixes after review

21fd96a

Merge pull request #5627 from multiversx/relayed_move_balance

564dc15

Separate fee handling for inner tx of type move balance

sstanculeanu added type:feature New feature or request area:processing impact:medium interested:protocol complexity:medium labels Nov 27, 2023

sstanculeanu self-assigned this Nov 27, 2023

sstanculeanu added 2 commits November 27, 2023 15:04

fixes after merge

7508eb9

sstanculeanu and others added 3 commits November 27, 2023 16:41

more fixes after merge

8b59d06

fix after review

5527e7b

Merge pull request #5742 from multiversx/merge_rc170_into_feat_relaye…

1917d06

…dv3_2023.11.27 Merge rc170 into feat relayedv3 2023.11.27

sstanculeanu and others added 7 commits January 30, 2024 11:06

fixes after merge

da58e7e

Merge pull request #5890 from multiversx/merge_rc170_into_feat_relaye…

a9f2893

…dv3_2024.01.30 Merge rc170 into feat relayedv3 2024.01.30

added api check for recursive relayed v3 + fixed interceptor

45dd9db

updated tests to make sure the previous issue is avoided

1423921

moved the check for recursive relayed before sig check on inner tx

142781c

Merge pull request #5981 from multiversx/relayedv3_fixes

8adf465

added api check for recursive relayed v3 + fixed interceptor

sstanculeanu changed the base branch from rc/v1.7.0 to rc/v1.7.next1 March 22, 2024 11:09

sstanculeanu and others added 7 commits March 22, 2024 13:42

updated mx-chain-core-go for feat/relayedV3

2a34318

updated txFee tests to use old values

2afa256

Merge pull request #6060 from multiversx/merge_rc17next1_into_feat_re…

d31d68b

…layedv3_2024.03.22 Merge rc17next1 into feat relayedv3 2024.03.22

fix after merge + updated core-go

637df8d

Merge pull request #6171 from multiversx/merge_rc17next1_into_feat/re…

ab49574

…layedv3_2024.05.15 Merge rc17next1 into feat/relayedv3 2024.05.15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/RelayedV3 #5741

Feat/RelayedV3 #5741

sstanculeanu commented Nov 27, 2023

codecov bot commented Nov 27, 2023 •

edited

Feat/RelayedV3 #5741

Are you sure you want to change the base?

Feat/RelayedV3 #5741

Conversation

sstanculeanu commented Nov 27, 2023

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

codecov bot commented Nov 27, 2023 • edited

Codecov Report

codecov bot commented Nov 27, 2023 •

edited