Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the nft processing queue name in configs #1251

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented May 15, 2024

Reasoning

  • At the moment the queue: 'api-process-nfts' is hardcoded in the code and the same rabbitmq cannot be used by 2 different api setups

Proposed Changes

  • Add the queue name for nft process queue in configs

@cfaur09 cfaur09 self-assigned this May 15, 2024
@cfaur09 cfaur09 added the feature New feature or request label May 15, 2024
danielailie
danielailie previously approved these changes May 15, 2024
bogdan-rosianu
bogdan-rosianu previously approved these changes May 16, 2024
@IosifGabriel
Copy link

Hello, I still think there needs to be done some concatetation for the deadLetterExchange as it remained hardcoded

deadLetterExchange: 'api-process-nfts-dlq',

deadLetterExchange: 'api-process-nfts-dlq',

@cfaur09 cfaur09 dismissed stale reviews from bogdan-rosianu and danielailie via ac09493 May 16, 2024 08:06
@cfaur09
Copy link
Contributor Author

cfaur09 commented May 16, 2024

Hello, I still think there needs to be done some concatetation for the deadLetterExchange as it remained hardcoded

deadLetterExchange: 'api-process-nfts-dlq',

deadLetterExchange: 'api-process-nfts-dlq',

Solved 🟢

Copy link
Contributor

@tanghel tanghel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make here a feature called "processNfts" and add there both the normal queue and the dead letter queue name. when reading the activation flag, try to read it first from features and then also from the "old" location to maintain backwards compatibility. update all config files with the new location. in this way we have all process nft-related functionality grouped together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants