add nodes feature requests #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfaur09
added
refactoring
bogdan-rosianu
previously approved these changes
Apr 24, 2024
add bls key for groups with no provider/identity and single node
add new specs
tanghel
approved these changes
May 17, 2024
IosifGabriel
pushed a commit
to buidly/mvx-api
that referenced
this pull request
May 22, 2024
* add nodes feature requests * add totalObservers field + tests * add totalObservers and nodes/auctions route * add groupBy identity and sortDescending by qualifiedStake * group also by owner * refactoring groupBy * add pagination * refactoring * refactorin groupBy * add distribution identity info * improved withIdentity query info * improved version of nodes/auctions data * convenient sorting defaults * add provider info value add bls key for groups with no provider/identity and single node * update tests * update nodes mock json add new specs * update shards.spec.ts * include totalObservers --------- Co-authored-by: tanghel <tanghel@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add following features:
/nodeswithIdentityInfofilter to be able to return for every node informations about identityqualifiedStakefieldqualifiedStakesort criteriawithIdentityInfofeature/staketotalObserversfieldtotalObserversfeatureHow to test
/nodes?withIdentityInfo=true-> should return for every nodeidentityInfofield/nodes?withIdentityInfo=false-> should not return for every nodeidentityInfofield/nodes?sort=qualifiedStake&order=desc-> should sort all nodes by qualifiedStake filter criteria desc/stake->totalObserversfield should be defined