Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove canMint and canBurn properties for token #1185

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Jan 18, 2024

Reasoning

  • If any token contains canAddSpecialRoles that means that he have canMint and canBurn roles

Proposed Changes

  • Remove for tokens canMint and canBurn properties

How to test

  • /tokens -> every token should not contain canMint and canBurn properties
  • /tokens/HSEGLD-c13a4e -> should not contain canMint and canBurn properties

@cfaur09 cfaur09 added the refactoring The same functionality is maintained, but in an improved way label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 46.20%. Comparing base (ecf9f53) to head (01bd50e).
Report is 149 commits behind head on development.

❗ Current head 01bd50e differs from pull request most recent head 0ab5865. Consider uploading reports for the commit 0ab5865 to get more accurate results

Files Patch % Lines
src/endpoints/accounts/account.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           development    #1185       +/-   ##
================================================
- Coverage        63.99%   46.20%   -17.79%     
================================================
  Files              576      594       +18     
  Lines            14895    15863      +968     
  Branches          1525     1694      +169     
================================================
- Hits              9532     7330     -2202     
- Misses            4021     6904     +2883     
- Partials          1342     1629      +287     
Flag Coverage Δ
integrationtests ?
unittests 46.20% <0.00%> (+12.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanghel tanghel added the breaking-change Functionality that works differently from previous version label Jan 18, 2024
@cfaur09 cfaur09 self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Functionality that works differently from previous version refactoring The same functionality is maintained, but in an improved way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants