Skip to content

Commit

Permalink
Fix highlight color in dark mode (#107)
Browse files Browse the repository at this point in the history
* Fix default

* Uncomment commented zip
  • Loading branch information
eatonphil committed Dec 6, 2021
1 parent 956d70f commit 644a996
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion desktop/scripts/release.build
Expand Up @@ -10,4 +10,4 @@ cp icon.png build/icon.png
cp icon.ico build/icon.ico
cp icon.icns build/icon.icns
yarn electron-packager --asar --overwrite --icon=build/icon.png --out=releases --build-version={arg0} --app-version={arg0} . "DataStation Community Edition"
# zip -9 -r releases/datastation-{os}-{arch}-{arg0}.zip "releases/DataStation Community Edition-{os}-{arch}"
zip -9 -r releases/datastation-{os}-{arch}-{arg0}.zip "releases/DataStation Community Edition-{os}-{arch}"
6 changes: 3 additions & 3 deletions ui/Header.tsx
Expand Up @@ -63,10 +63,10 @@ export function Header() {
<span>{projectId}</span>
)}
<Toggle
label={settings.theme === 'light' ? 'Light Mode' : 'Dark Mode'}
value={settings.theme !== 'light'}
label={settings.theme !== 'dark' ? 'Light Mode' : 'Dark Mode'}
value={settings.theme === 'dark'}
onChange={function handleLightModeToggle() {
settings.theme = settings.theme === 'light' ? 'dark' : 'light';
settings.theme = settings.theme === 'dark' ? 'light' : 'dark';
setSettings(settings);
}}
/>
Expand Down
3 changes: 2 additions & 1 deletion ui/style.css
Expand Up @@ -964,7 +964,8 @@ body.dark {
background: #181824;
}

.ace_layer.ace_marker-layer .ace_active-line {
.ace_layer.ace_marker-layer .ace_active-line,
.ace_layer.ace_marker-layer .ace_selection {
background: rgba(0, 0, 0, 0.5);
}

Expand Down

0 comments on commit 644a996

Please sign in to comment.